Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of RTT estimation section #2592

Merged
merged 16 commits into from Apr 12, 2019
Merged

Rewrite of RTT estimation section #2592

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
524bc02
rewrite of RTT estimate sectionbn
janaiyengar Apr 8, 2019
59751b7
fix lint
janaiyengar Apr 8, 2019
bf9f483
update pseudocode
janaiyengar Apr 8, 2019
f4dddc5
Update draft-ietf-quic-recovery.md
martinthomson Apr 8, 2019
1ec3a95
Update draft-ietf-quic-recovery.md
martinthomson Apr 8, 2019
6bfea40
Update draft-ietf-quic-recovery.md
martinthomson Apr 8, 2019
21a0bda
martin's comments
janaiyengar Apr 9, 2019
c2b9da0
s/corrected/adjusted
janaiyengar Apr 9, 2019
f0c860d
s/ack delay/host delay
janaiyengar Apr 9, 2019
cb683af
moving host delay section to under Generating Acks
janaiyengar Apr 9, 2019
0b38d2c
nit
janaiyengar Apr 9, 2019
9be9f1a
ian's comments
janaiyengar Apr 9, 2019
39b6ef6
Ian's comments
janaiyengar Apr 10, 2019
9b9973c
Update draft-ietf-quic-recovery.md
ianswett Apr 11, 2019
9cf7d92
Update draft-ietf-quic-recovery.md
ianswett Apr 12, 2019
77d6256
reflow
janaiyengar Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -1063,10 +1063,15 @@ OnAckReceived(ack, pn_space):
largest_acked_packet[pn_space] =
max(largest_acked_packet[pn_space], ack.largest_acked)

// Nothing to do if there are no newly acked packets.
newly_acked_packets = DetermineNewlyAckedPackets(ack, pn_space)
if (newly_acked_packets.empty()):
return

// If the largest acknowledged is newly acked and
// ack-eliciting, update the RTT.
// at least one ack-eliciting was newly acked, update the RTT.
if (sent_packets[pn_space][ack.largest_acked] &&
sent_packets[pn_space][ack.largest_acked].ack_eliciting):
IncludesAckEliciting(newly_acked_packets))
latest_rtt =
now - sent_packets[pn_space][ack.largest_acked].time_sent
UpdateRtt(latest_rtt, ack.ack_delay)
Expand All @@ -1075,11 +1080,6 @@ OnAckReceived(ack, pn_space):
if (ACK frame contains ECN information):
ProcessECN(ack)

// Find all newly acked packets in this ACK frame
newly_acked_packets = DetermineNewlyAckedPackets(ack, pn_space)
if (newly_acked_packets.empty()):
return

for acked_packet in newly_acked_packets:
OnPacketAcked(acked_packet.packet_number, pn_space)

Expand Down