Specify HEADERS on control stream error. #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This inconsistency was bugging me the other day. So thanks for beating me to fixing it :) @MikeBishop iff #2678 gets traction, we'd need a sweep of all these |
|
@MikeBishop #2678 was closed. Is there anything else that's blocking this pr from being merged? |
kazuho
reviewed
Jun 9, 2019
Receiving a HEADERS frame on a control stream should result in a connection error of type HTTP_WRONG_STREAM.
ianswett
approved these changes
Jun 10, 2019
|
@DaanDeMeyer I added @MikeBishop so he can review and merge this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving a HEADERS frame on a control stream should result in a connection error of type HTTP_WRONG_STREAM.
The correct error is documented for all other frame types except for HEADERS. This pr specifies the error for HEADERS frames as well.