Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GOAWAY errors properly #2713

Closed
wants to merge 1 commit into from
Closed

Fix GOAWAY errors properly #2713

wants to merge 1 commit into from

Conversation

MikeBishop
Copy link
Contributor

@MikeBishop MikeBishop commented May 16, 2019

In #2705, @DaanDeMeyer correctly observed that I messed up #2343, but he closed his PR and I'm not able to reopen it without more git wizardry than I'm interested in practicing today. Easier just to fix it in my own branch.

So:

  • GOAWAY properly sent by the server on the control stream, but containing the wrong stream ID can't be WRONG_STREAM, it should be MALFORMED_FRAME.
  • GOAWAY sent by the server on something other than the control frame isn't UNEXPECTED_FRAME, it's WRONG_STREAM (see aside with @kazuho about whether the distinction actually matters, but in the interest of keeping the document internally consistent....)
  • GOAWAY sent by a client is UNEXPECTED_FRAME, and that's the only one I got right before.

Fixes #2714.

@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -http labels May 16, 2019
@MikeBishop
Copy link
Contributor Author

Whoops -- missed that #2707 was the updated version of #2705. Closing in favor of @DaanDeMeyer's, which contains identical text.

@MikeBishop MikeBishop closed this May 16, 2019
@janaiyengar janaiyengar deleted the http/goaway_error branch May 22, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GOAWAY errors are wrong
1 participant