Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify error for a DATA frame before any HEADERS frames #2715

Merged
merged 4 commits into from Jun 12, 2019

Conversation

MikeBishop
Copy link
Contributor

#2712 reincarnated, because I messed up. Sorry, @DaanDeMeyer.

@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -http labels May 16, 2019
@@ -423,6 +423,10 @@ must be received and processed before the message can be consumed. See
The "chunked" transfer encoding defined in Section 4.1 of {{!RFC7230}} MUST NOT
be used.

If a DATA frame is received before a HEADERS frame on a request stream, the
recipient must respond with a connection error ({{errors}}) of type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recipient must respond with a connection error ({{errors}}) of type
recipient MUST respond with a connection error of type HTTP_UNEXPECTED_FRAME

@@ -423,6 +423,10 @@ must be received and processed before the message can be consumed. See
The "chunked" transfer encoding defined in Section 4.1 of {{!RFC7230}} MUST NOT
be used.

If a DATA frame is received before a HEADERS frame on a request stream, the
recipient must respond with a connection error ({{errors}}) of type
HTTP_UNEXPECTED_FRAME.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HTTP_UNEXPECTED_FRAME.
({{errors}}).

Copy link
Member

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but don't forget push

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
Co-Authored-By: Lucas Pardue <lucaspardue.24.7@gmail.com>
@MikeBishop MikeBishop force-pushed the DaanDeMeyer-specify-data-before-headers-error branch from 1727343 to bda6173 Compare May 20, 2019 17:50
@MikeBishop MikeBishop merged commit b0b4478 into master Jun 12, 2019
@MikeBishop MikeBishop deleted the DaanDeMeyer-specify-data-before-headers-error branch June 12, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants