Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better articulate principles for ciphersuites #2743

Merged
merged 2 commits into from May 22, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions draft-ietf-quic-tls.md
Expand Up @@ -833,9 +833,9 @@ and produce an output 16 bytes larger than their input.

Note:

: An endpoint MUST NOT reject a ClientHello that offers a ciphersuite that
offers a ciphersuite that it does not support, or it would be impossible to
deploy a new ciphersuite. This also applies to TLS_AES_128_CCM_8_SHA256.
: An endpoint MUST NOT reject a ClientHello that offers a ciphersuite that it
does not support, or it would be impossible to deploy a new ciphersuite. This
also applies to TLS_AES_128_CCM_8_SHA256.

The key and IV for the packet are computed as described in {{protection-keys}}.
The nonce, N, is formed by combining the packet protection IV with the packet
Expand Down Expand Up @@ -969,7 +969,7 @@ sample.

To ensure that sufficient data is available for sampling, packets are padded so
that the combined lengths of the encoded packet number and protected payload is
at least 4 bytes longer than the sample required for header protection. For the
at least 4 bytes longer than the sample required for header protection. The
ciphersuites defined in {{?TLS13}} - other than TLS_AES_128_CCM_8_SHA256, for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove "For" (the sentence should start "The ciphersuites defined in").

which a header protection scheme is not defined in this document - have 16-byte
expansions and 16-byte header protection samples. This results in needing at
Expand Down