Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove misleading sentence about incompatible QUIC versions and ALPN #2802

Merged
merged 2 commits into from
Sep 10, 2019
Merged

remove misleading sentence about incompatible QUIC versions and ALPN #2802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924ad85
remove misleading sentence about incompatible QUIC versions and ALPN
marten-seemann Jun 18, 2019
818290b
apply Mike's suggestion
marten-seemann Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,8 +1279,8 @@ An application-layer protocol MAY restrict the QUIC versions that it can operate
over. Servers MUST select an application protocol compatible with the QUIC
Copy link
Contributor

@mikkelfj mikkelfj Jun 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural singular mix: Servers vs the server. Perhaps use "a server"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR.

version that the client has selected. If the server cannot select a compatible
combination of application protocol and QUIC version, it MUST abort the
connection. A client MUST abort a connection if the server picks an incompatible
combination of QUIC version and ALPN identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement is still true. If you object to the implication of the server picking a version, maybe this should be "A client MUST abort a connection if the server picks an application protocol incompatible with the protocol version being used."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that one. Just updated the PR.

connection. A client MUST abort a connection if the server picks an application
protocol incompatible with the protocol version being used.


## QUIC Transport Parameters Extension {#quic_parameters}
Expand Down