New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Crypto timeout and PTO #2806
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3580c61
Update draft-ietf-quic-recovery.md
ianswett 98fbe4a
Update draft-ietf-quic-recovery.md
ianswett fa3b549
Update draft-ietf-quic-recovery.md
ianswett ab199a4
Update draft-ietf-quic-recovery.md
ianswett f4a7915
Update draft-ietf-quic-recovery.md
ianswett 7ce89c2
Update draft-ietf-quic-recovery.md
ianswett 3a10638
Remove crypto timer from the pseudocode
ianswett 50d6fff
Update draft-ietf-quic-recovery.md
ianswett cc80198
Update draft-ietf-quic-recovery.md
ianswett 80c67ed
Update draft-ietf-quic-recovery.md
ianswett 8768272
Update draft-ietf-quic-recovery.md
ianswett 342c793
Update draft-ietf-quic-recovery.md
ianswett 48c1a46
Update draft-ietf-quic-recovery.md
ianswett b46c107
Update draft-ietf-quic-recovery.md
ianswett 69fdaa4
Update draft-ietf-quic-recovery.md
ianswett f399b5a
Changed to MUST
ianswett 6ab3dcd
Update draft-ietf-quic-recovery.md
ianswett 2dff033
Update draft-ietf-quic-recovery.md
ianswett 21c7924
Update draft-ietf-quic-recovery.md
ianswett d457011
Update draft-ietf-quic-recovery.md
ianswett fcccfff
Update draft-ietf-quic-recovery.md
ianswett fb1f327
Update draft-ietf-quic-recovery.md
ianswett d3adee4
Ryan's suggestion
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably obvious but it doesn't seem to explicitly say what causes 1 vs 2 packet to be sent. Perhaps this is clear elsewhere? I wonder if it might make sense to say something like "two packets, if there is sufficient data available, and one otherwise". But maybe that's not really helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 1 or 2 because some impls only do 1 packet PTO(TLP). I could recommend two packets during the handshake, in order to speed handshake completion?
It actually should be datagrams, but I'm inclined to change that in a follow-up, rather that burying it in this change?