Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR #2808
Conversation
draft-ietf-quic-http.md
Outdated
| @@ -2174,8 +2174,7 @@ NO_ERROR (0x0): | |||
| : HTTP_NO_ERROR in {{http-error-codes}}. | |||
|
|
|||
| PROTOCOL_ERROR (0x1): | |||
| : No single mapping. See new HTTP_MALFORMED_FRAME error codes defined in | |||
| {{http-error-codes}}. | |||
| : HTTP_GENERAL_PROTOCOL ERROR in {{http-error-codes}}. | |||
There was a problem hiding this comment.
Isn't it still the case that we have multiple error codes that map to HTTP_GENERAL_PROTOCOL error in HTTP/2?
Or are we going to merge all the connection-level error codes that do not map to an error code in HTTP/2 (e.g., WRONG_STREAM, UNEXPECTED_FRAME, CLOSED_CRITICAL_STREAM) to HTTP_GENERAL_PROTOCOL?
There was a problem hiding this comment.
I don't follow sorry. This section states:
QUIC has the same concepts of “stream” and “connection” errors that HTTP/2 provides. However, there is no direct portability of HTTP/2 error codes.
The change is intended to address how the HTTP/2 error code PROTOCOL_ERROR, for HTTP/3 non-connection errors (usually frame errors), is equivalently expressed.
How would you suggest improving this?
There was a problem hiding this comment.
Maybe I should have stated that the removal of "No single mapping." is concerning, because IIUC we do not have one-to-one mapping between PROTOCOL_ERROR (of HTTP/2) and HTTP_GENEAL_PROTOCOL error (of HTTP/3).
What I had in mind is something like "Split into a few error codes, including HTTP_GENERAL_PROTOCOL, HTTP_WRONG_STREAM, HTTP_UNEXPECTED_FRAME, HTTP_CLOSED_CRITICAL_STREAM."
There was a problem hiding this comment.
Thanks, I agree and would like to adopt that text. The annoying thing is that it add more references to error codes I'm looking to consolidate but I can try to update the text to match the state of the draft as the PRs get merged.
draft-ietf-quic-http.md
Outdated
| @@ -2174,7 +2174,9 @@ NO_ERROR (0x0): | |||
| : HTTP_NO_ERROR in {{http-error-codes}}. | |||
|
|
|||
| PROTOCOL_ERROR (0x1): | |||
| : No single mapping. See new HTTP_MALFORMED_FRAME error codes defined in | |||
| : No single mapping. Split into a few error codes, including | |||
There was a problem hiding this comment.
| : No single mapping. Split into a few error codes, including | |
| : No single mapping. Split into multiple error codes, including |
There was a problem hiding this comment.
I would say that "This is mapped to HTTP_GENERAL_PROTOCOL_ERROR except in cases where more specific error codes have been defined. This includes HTTP_MALFORMED_FRAME, ...
There was a problem hiding this comment.
thanks, I applied your suggestion @martinthomson
Fixes #2807