Fix grammar in 3.2. Receiving Stream States #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkey-mas
commented
Jun 23, 2019
draft-ietf-quic-transport.md
Outdated
| @@ -526,7 +526,7 @@ an unopened stream indicates that the remote peer no longer wishes to receive | |||
| data on this stream. Either frame might arrive before a STREAM or | |||
| STREAM_DATA_BLOCKED frame if packets are lost or reordered. | |||
|
|
|||
| Before creating a stream, all streams of the same type with lower-numbered | |||
| Before a new stream is created, all streams of the same type with lower-numbered | |||
There was a problem hiding this comment.
Maybe we don't have to clearly say "new".
There was a problem hiding this comment.
Yeah, I don't think we need "new" in the sentence.
There was a problem hiding this comment.
Thanks! Fixed it.
nibanks
approved these changes
Jun 23, 2019
draft-ietf-quic-transport.md
Outdated
| @@ -526,7 +526,7 @@ an unopened stream indicates that the remote peer no longer wishes to receive | |||
| data on this stream. Either frame might arrive before a STREAM or | |||
| STREAM_DATA_BLOCKED frame if packets are lost or reordered. | |||
|
|
|||
| Before creating a stream, all streams of the same type with lower-numbered | |||
| Before a new stream is created, all streams of the same type with lower-numbered | |||
There was a problem hiding this comment.
Yeah, I don't think we need "new" in the sentence.
monkey-mas
force-pushed
the
fix-grammar-in-3-2-ReceivingStreamStates
branch
from
0ca7bee
to
ff1698f
Compare
The phrase, `Before creating a stream, all streams of the same type with lower-numbered stream IDs MUST be created.`, is semantically equal to `Before all streams (of the same type with lower-numbered stream IDs) create a stream, all streams of the same type with lower-numbered stream IDs MUST be created.` This is not correct since all streams don't create a (new) stream. Moreover, by definition, a stream is created by sending data[1] or STREAM frames implicitly create a stream[2]. This indicates a stream itself doesn't create another stream. [1] https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-2 [2] https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-19.8
martinthomson
added
-transport
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phrase,
Before creating a stream, all streams of the same type with lower-numbered stream IDs MUST be created., is semantically equal toBefore all streams (of the same type with lower-numbered stream IDs) create a stream, all streams of the same type with lower-numbered stream IDs MUST be created.This is not correct since all streams don't create a (new) stream. Moreover, by definition, a stream is created by sending data[1] or STREAM frames implicitly create a stream[2]. This indicates a stream itself doesn't create another stream.
[1] https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-2
[2] https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-19.8