Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten HEADERS and DATA frame order requirements. #2867

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Tighten HEADERS and DATA frame order requirements. #2867

merged 4 commits into from
Aug 2, 2019

Conversation

bencebeky
Copy link
Contributor

  • Clarify HTTP message definition.
  • Require the connection to be closed upon receipt of frames in
    incorrect order.
  • Refer to HTTP messages in push stream section.

This addresses #2858.

@ianswett ianswett requested a review from MikeBishop July 2, 2019 17:39
@ianswett ianswett added the -http label Jul 2, 2019
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text was already somewhat lacking by not discussing the possibility of extension frames being interleaved; stating that the push stream consists of "responses" rather than "frames" extends this shortcoming to the push stream section.

I'm open to fixing this in a separate PR, if you prefer, though.

* Clarify HTTP message definition.
* Require the connection to be closed upon receipt of frames in
  incorrect order.
* Refer to HTTP messages in push stream section.

This addresses #2858.
@bencebeky
Copy link
Contributor Author

This text was already somewhat lacking by not discussing the possibility of extension frames being interleaved; stating that the push stream consists of "responses" rather than "frames" extends this shortcoming to the push stream section.

I'm open to fixing this in a separate PR, if you prefer, though.

Good catch. I added a paragraph to explicitly allow unknown frames to the message exchange section. I also modified the wording in the push section to be more permissive of interleaved frames ("by" instead of "consists of").

@LPardue
Copy link
Member

LPardue commented Jul 21, 2019

LGTM

@MikeBishop MikeBishop merged commit e02d458 into quicwg:master Aug 2, 2019
@bencebeky bencebeky deleted the bencebeky-headers-and-data-order branch August 3, 2019 00:31
@juliens juliens mentioned this pull request Oct 12, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants