Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Recovery Pseudocode #2907

Merged
merged 25 commits into from Sep 4, 2019
Merged

Fix Recovery Pseudocode #2907

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ad064cc
Update draft-ietf-quic-recovery.md
ianswett Jul 17, 2019
d1d9bc9
Consistent ifs
ianswett Jul 19, 2019
26ecb8f
Martin Duke's suggestion
ianswett Jul 20, 2019
b977940
Remove ||
ianswett Jul 21, 2019
f079e9d
Use || and && consistently
ianswett Jul 21, 2019
08ea0f5
Merge branch 'master' into ianswett-fix-loss-detection
ianswett Jul 21, 2019
59c3af3
Update draft-ietf-quic-recovery.md
ianswett Jul 21, 2019
fef247f
Martin's suggestion
ianswett Aug 23, 2019
e97e175
Jana's suggestion
ianswett Aug 24, 2019
b47dbbc
nit
janaiyengar Aug 27, 2019
617c4a7
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
d2d1bb8
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
fd8bdd7
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
9a77e26
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
8eab33d
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
4df7494
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
04ac7b2
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
9f0d6ec
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
26119bd
Update draft-ietf-quic-recovery.md
ianswett Sep 3, 2019
ec34d08
Add PeerAwaitingAddressValidation
ianswett Sep 4, 2019
e8e778c
Update draft-ietf-quic-recovery.md
ianswett Sep 4, 2019
d0b5498
Update draft-ietf-quic-recovery.md
ianswett Sep 4, 2019
c212dfd
Some of MT's suggestions
ianswett Sep 4, 2019
92b5fd7
Update draft-ietf-quic-recovery.md
ianswett Sep 4, 2019
d55a153
Update draft-ietf-quic-recovery.md
ianswett Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -1175,7 +1175,7 @@ GetEarliestLossTime():
space = Initial
for pn_space in [ Handshake, ApplicationData ]:
if (loss_time[pn_space] != 0 &&
(time == 0 || loss_time[pn_space] < time)):
(time == 0 or loss_time[pn_space] < time)):
ianswett marked this conversation as resolved.
Show resolved Hide resolved
time = loss_time[pn_space];
space = pn_space
return time, space
Expand Down Expand Up @@ -1270,7 +1270,7 @@ DetectLostPackets(pn_space):
continue

// Mark packet as lost, or set time when it should be marked.
if (unacked.time_sent <= lost_send_time ||
if (unacked.time_sent <= lost_send_time or
largest_acked_packet[pn_space] >=
unacked.packet_number + kPacketThreshold):
sent_packets[pn_space].remove(unacked.packet_number)
Expand Down