Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTO should always send an ack-eliciting packet #2912

Merged
merged 2 commits into from Jul 21, 2019
Merged

PTO should always send an ack-eliciting packet #2912

merged 2 commits into from Jul 21, 2019

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Jul 21, 2019 •
edited

Fixes #2895 which discusses sending an ack-eliciting packet instead of a PADDING only packet to unblock the server.

erickinnear
erickinnear approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@erickinnear erickinnear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for what it's worth our implementation always bundles a PING in here if there is nothing else ack-eliciting to send.

janaiyengar
janaiyengar approved these changes Jul 21, 2019
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@janaiyengar janaiyengar mentioned this pull request Jul 21, 2019
Closed
ianswett
ianswett commented Jul 21, 2019
View reviewed changes
Copy link
Contributor Author

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes Jana, this LGTM.

@janaiyengar janaiyengar merged commit 0d68417 into master Jul 21, 2019
@janaiyengar janaiyengar mentioned this pull request Jul 21, 2019
Merged
@ghedo ghedo mentioned this pull request Sep 15, 2019
Closed
@MikeBishop MikeBishop deleted the ianswett-pto-ack-eliciting branch March 18, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaiyengar janaiyengar janaiyengar approved these changes

@erickinnear erickinnear erickinnear approved these changes

Assignees
No one assigned
Labels
-recovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advise bundling a PING or other small ACK eliciting frame with Initials
3 participants
@ianswett @janaiyengar @erickinnear