Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up to two full-sized datagrams, not packets #2915

Merged
merged 5 commits into from
Jul 21, 2019
Merged

Conversation

ianswett
Copy link
Contributor

Now that the PTO retransmits Initial and Handshake data, it's possible and likely desirable to bundle multiple QUIC packets in a single datagram. This change makes it clear that is allowed.

Now that the PTO retransmits Initial and Handshake data, it's possible and likely desirable to bundle multiple QUIC packets in a single datagram.  This change makes it clear that is allowed.
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
to two ack-eliciting packets, to avoid an expensive consecutive PTO expiration
due to a single packet loss.
to two full sized datagrams containing ack-eliciting packets, to avoid an
expensive consecutive PTO expiration due to a single lost datagram.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is that limit of two specified? Here? Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you send 1, it might be lost. Ideally, fewer is better, so the question of 1 or 2 was left to implementers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, there is no limit to coalescing AFAIK, so the limit of two here seems arbitrary, albeit probably very sensible.
https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#rfc.section.12.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no limit of 2 packets in a datagram here and I don't think there's one elsewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An endpoint MAY send up to two full-sized datagrams containing ack-eliciting packets,

I read that as it MAY NOT send more than two, but it MAY send less.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I am confusing UDP datagrams and packets.

Co-Authored-By: MikkelFJ <mikkelfj@gmail.com>
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, but lgtm

ianswett and others added 3 commits July 21, 2019 15:26
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
@ianswett ianswett merged commit d3c66d2 into master Jul 21, 2019
@MikeBishop MikeBishop deleted the ianswett-pto-datagrams branch March 18, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants