Talk more about multiple tokens #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
marten-seemann
approved these changes
Aug 15, 2019
ianswett
approved these changes
Aug 15, 2019
draft-ietf-quic-transport.md
Outdated
| {{migration-linkability}}. A client MUST NOT reuse a token if it believes that | ||
| its point of network attachment has changed since the token was last used; that | ||
| is, if there is a change in its local IP address or network interface. A client | ||
| needs to start the connection process over if it migrates prior to completing |
There was a problem hiding this comment.
I think it'd be preferable to avoid the word 'migrate' here, and reuse the preceding text: "if there is a change in its local IP address or network interface."?
draft-ietf-quic-transport.md
Outdated
| the handshake. | ||
|
|
||
| Clients might receive multiple tokens on a single connection. Aside from | ||
| preventing linkability, any token can be used in connection attempt. Servers |
There was a problem hiding this comment.
Suggested change
| preventing linkability, any token can be used in connection attempt. Servers | |
| preventing linkability, any token can be used in any connection attempt. Servers |
I think this is what you meant?
This addresses some questions about use of multiple tokens, as well as cleaning up the text adjacent in minor ways. Closes #2801.
martinthomson
force-pushed
the
multi-token
branch
from
53b8707
to
992fa67
Compare
MikeBishop
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some questions about use of multiple tokens, as well as
cleaning up the text adjacent in minor ways.
Closes #2801.