-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ClientHello to span multiple QUIC packets #3045
Merged
martinthomson
merged 9 commits into
quicwg:master
from
DavidSchinazi:multi_packet_client_hello
Oct 31, 2019
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7af6d61
Allow ClientHello to span multiple QUIC packets
DavidSchinazi c2c7abb
MT review comment
DavidSchinazi 3ae146d
Merge branch 'master' into multi_packet_client_hello
DavidSchinazi c1eeb6e
MT review comments
DavidSchinazi 0a2645f
Another MT review comment
DavidSchinazi c2d175f
MT suggestions
DavidSchinazi da7b436
reflow
DavidSchinazi 9951381
Merge branch 'master' into multi_packet_client_hello
DavidSchinazi 5569542
Review comments from Ian
DavidSchinazi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1298,15 +1298,6 @@ properties: | |
* authenticated negotiation of an application protocol (TLS uses ALPN | ||
{{?RFC7301}} for this purpose) | ||
|
||
The first CRYPTO frame from a client MUST be sent in a single packet. Any | ||
second attempt that is triggered by address validation (see | ||
{{validate-handshake}}) MUST also be sent within a single packet. This avoids | ||
having to reassemble a message from multiple packets. | ||
|
||
The first client packet of the cryptographic handshake protocol MUST fit within | ||
a 1232 byte QUIC packet payload. This includes overheads that reduce the space | ||
available to the cryptographic handshake protocol. | ||
|
||
An endpoint can verify support for Explicit Congestion Notification (ECN) in the | ||
first packets it sends, as described in {{ecn-validation}}. | ||
|
||
|
@@ -3959,16 +3950,15 @@ Initial packet containing other frames can either discard the packet as spurious | |
or treat it as a connection error. | ||
|
||
The first packet sent by a client always includes a CRYPTO frame that contains | ||
the entirety of the first cryptographic handshake message. This packet, and the | ||
cryptographic handshake message, MUST fit in a single UDP datagram (see | ||
{{handshake}}). The first CRYPTO frame sent always begins at an offset of 0 | ||
(see {{handshake}}). | ||
|
||
Note that if the server sends a HelloRetryRequest, the client will send a second | ||
Initial packet. This Initial packet will continue the cryptographic handshake | ||
and will contain a CRYPTO frame with an offset matching the size of the CRYPTO | ||
frame sent in the first Initial packet. Cryptographic handshake messages | ||
subsequent to the first do not need to fit within a single UDP datagram. | ||
the start or all of the first cryptographic handshake message. The first | ||
CRYPTO frame sent always begins at an offset of 0 (see {{handshake}}). | ||
|
||
Note that if the server sends a HelloRetryRequest, the client will send another | ||
series of Initial packets. These Initial packets will continue the | ||
cryptographic handshake and will contain CRYPTO frames starting at an offset | ||
matching the size of the CRYPTO frames sent in the first flight of Initial | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "matching the size" is a bit odd. Perhaps "immediately after the last byte of..." |
||
packets. | ||
|
||
|
||
#### Abandoning Initial Packets {#discard-initial} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or address tokens, presumably?