New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that clients don't need to remember unknown SETTINGS #3113
Conversation
draft-ietf-quic-http.md
Outdated
frame which reduces a setting the client understands or omits a value that was | ||
previously specified to have a non-default value, this MUST be treated as a | ||
connection error of type HTTP_SETTINGS_ERROR. | ||
their default values. If a server accepts 0-RTT but then sends a SETTINGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reserved settings do not have a default value, so I don't know if we need to call that out here specifically. If we do it affects the readability a little bit; perhaps we can rely on the readers implicit understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's implied - if a reserved setting was specified, then it was specified to have a non-default value (since there is no default value).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM
draft-ietf-quic-http.md
Outdated
previously specified to have a non-default value, this MUST be treated as a | ||
connection error of type HTTP_SETTINGS_ERROR. | ||
their default values. If a server accepts 0-RTT but then sends a SETTINGS | ||
frame which reduces setting the client understands, this MUST be treated as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting consequence of the "reduces" clause here is that you can't define a "supports" setting with 0=supports and 1=doesn't support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduces "a" setting. #2972 switched to using the term "compatible" up at lines 1215-1216, including a definition of the term; perhaps using "incompatible" instead of "reduces" here as well would help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the missing "a" in "reduces a setting" (although it's moot now that I've reworded this).
I like using the term "compatible" instead of reduces, since it avoids this odd edge case and imo is more specific.
4145b05
to
ab355c5
Compare
Fixes #3110.