Forbid use of application-level close in Initial, Handshake packets #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
I think this is the right way to go, since during the non-0-RTT handshake, the peers don't agree on the application protocol.
However, I've written in #3158 (comment), I think we might need a way to communicate an application-level error code for 0-RTT connections.
martinthomson
approved these changes
Oct 29, 2019
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
marten-seemann
approved these changes
Oct 30, 2019
mikkelfj
reviewed
Oct 30, 2019
nibanks
approved these changes
Oct 30, 2019
ianswett
approved these changes
Oct 30, 2019
martinthomson
approved these changes
Oct 30, 2019
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
MikeBishop
approved these changes
Oct 31, 2019
martinthomson
added
the
design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3158, use of application-level close is problematic in Initial / Handshake packets.
This PR address the issue by limiting the use of that to 1-RTT packets, at the same time advising applications to use user_canceled TLS alert to abort the connection during the handshake.
Closes #3158.