kMaxDatagramSize -> max_datagram_size #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies that this is the maximum datagram size currently in use on the connection. Fixes #3041
martinthomson
approved these changes
Oct 29, 2019
draft-ietf-quic-recovery.md
Outdated
| max_datagram_size: | ||
| : The sender's current maximum payload size. Does not include UDP or IP | ||
| overhead. The max datagram size is used for calculating initial and | ||
| minimum congestion windows. The RECOMMENDED value is 1200 bytes. |
There was a problem hiding this comment.
This can't be less than 1200. Worth adding?
janaiyengar
requested changes
Oct 29, 2019
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
janaiyengar
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that this is the maximum datagram size currently in use on the connection.
Fixes #3041