Deny 1-RTT Rx keys till finished #3174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
kazuho
reviewed
Oct 31, 2019
| @@ -504,6 +504,9 @@ client could interleave ACK frames that are protected with Handshake keys with | |||
| 0-RTT data and the server needs to process those acknowledgments in order to | |||
| detect lost Handshake packets. | |||
|
|
|||
| A TLS implementation MUST NOT provide a 1-RTT decrypt secret to QUIC until it | |||
| the TLS handshake is complete. | |||
There was a problem hiding this comment.
As stated in #3173 (comment), I do not think we should be using a normative word here, as this is a requirement in the TLS 1.3 handshake protocol (specifycally the one stated in section 4.4.4).
QUIC is a user of the TLS handshake protocol (like DTLS 1.3), and we should not re-mandate a behavior that the TLS handshake protocol already requires you to do.
That said, I am fine with editors making the choice.
There was a problem hiding this comment.
I'm persuaded by Kazuho's argument here. I don't think that we need the whole appendix, but a note on this might be worth adding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3173.