Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CWND increase in slow start #3183

Closed
wants to merge 1 commit into from

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Nov 1, 2019

When not pacing packets, limit the CWND increase to 2 packets per ACK frame received and cite RFC3465.

Fixes #3094

When not pacing packets, limit the CWND increase to 2 packets per ACK frame received and cite RFC3465.

Fixes #3094
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but Vidhi is working on a PR for this that includes pseudo-code changes. I'd suggest that we wait for that.

@ianswett
Copy link
Contributor Author

ianswett commented Nov 1, 2019

Given pacing is the recommended approach, what is the motivation to change the pseudocode?

@janaiyengar
Copy link
Contributor

The text is reflected in the psuedo-code, so changes to text should be reflected as well. I think it's useful to provide code for those not pacing.

@martinthomson martinthomson added the design An issue that affects the design of the protocol; resolution requires consensus. label Nov 4, 2019
@ianswett ianswett closed this Dec 10, 2019
@MikeBishop MikeBishop deleted the ianswett-limit-cwnd-increase branch March 18, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

congestion window increase on every ACKed packet could result in bursty sends
4 participants