-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer text for application errors #3226
Conversation
This cribs Lucas' proposed tweak and makes a few other tiny adjustments. Closes #2850.
draft-ietf-quic-transport.md
Outdated
streams that are prematurely cancelled by either endpoint. | ||
Resetting a stream without the involvement of the application protocol could | ||
cause the application protocol to enter an unrecoverable state. Application | ||
protocols might require certain streams to be reliably delivered in order to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to split hairs what does "might require certain streams to be reliably delivered" really mean here? Streams produce reliable byte streams. Is the intent more to say something like "applications expect streams to run to completion" and that premature exit causes that assumption to break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Lucas point. Personally, I'd delete this sentence because I think it's not adding much and as written it's confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the "critical stream" idea from HTTP/3 -- if you blow up a request stream, the HTTP connection is fine. If you blow up a QPACK stream, the connection dies in flames. Some streams are application-critical, and only the application knows which, so only the application can decide which streams to kill. In a transport world, though, "reliably delivered" brings up different overtones. Maybe "Resetting certain streams could disrupt the consistency of application-layer state between the endpoints."?
As to confusion, this is the rationale for the restriction in the previous paragraph. Maybe putting the rationale first and following with "Therefore, RESET_STREAM MUST only be instigated...." would help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments
draft-ietf-quic-transport.md
Outdated
streams that are prematurely cancelled by either endpoint. | ||
Resetting a stream without the involvement of the application protocol could | ||
cause the application protocol to enter an unrecoverable state. Application | ||
protocols might require certain streams to be reliably delivered in order to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Lucas point. Personally, I'd delete this sentence because I think it's not adding much and as written it's confusing.
Co-Authored-By: Mike Bishop <mbishop@evequefou.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This cribs Lucas' proposed tweak and makes a few other tiny adjustments.
Closes #2850.