Recovery editorial update #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
added
editorial
martinduke
approved these changes
Nov 17, 2019
janaiyengar
reviewed
Nov 20, 2019
| @@ -549,9 +544,7 @@ expired, the sender SHOULD send ack-eliciting packets from other packet | |||
| number spaces with in-flight data, coalescing packets if possible. | |||
|
|
|||
| When the PTO timer expires, and there is new or previously sent unacknowledged | |||
| data, it MUST be sent. Data that was previously sent with Initial encryption | |||
| MUST be sent before Handshake data and data previously sent at Handshake | |||
| encryption MUST be sent before any ApplicationData data. | |||
There was a problem hiding this comment.
Why are you removing this text?
There was a problem hiding this comment.
This should have been removed in #3066, but was missed.
janaiyengar
approved these changes
Nov 20, 2019
Update based on my review of the editor's copy.
janaiyengar
force-pushed
the
ianswett-recovery-editorial
branch
from
9725dba
to
258f2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update based on my review of the editor's copy.