Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for Retry integrity protection, use values that can be derived from AEAD API #3365

Merged
merged 2 commits into from
Jan 21, 2020
Merged

for Retry integrity protection, use values that can be derived from AEAD API #3365

merged 2 commits into from
Jan 21, 2020

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Jan 19, 2020 •
edited
Loading

Closes #3366.

martinthomson
martinthomson approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the outcome, then this seems fine.

draft-ietf-quic-tls.md Outdated Show resolved Hide resolved
janaiyengar
janaiyengar approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful -- we should merge this.

@martinthomson martinthomson added -tls editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jan 21, 2020
@martinthomson martinthomson merged commit 7713391 into quicwg:master Jan 21, 2020
@martinthomson
Copy link
Member

Just to set expectations, I think that I want to reserve the ability to pick new values for these. Just as there will be a new value for the Initial salt when we publish an RFC, this probably needs a new value at the same time.

@marten-seemann marten-seemann mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

Assignees
No one assigned
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry integrity protection should not add new requirements to TLS API
3 participants
@kazuho @martinthomson @janaiyengar