Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error code and reason phrase from GOAWAY #355

Merged
merged 7 commits into from
Mar 8, 2017
Merged

Remove error code and reason phrase from GOAWAY #355

merged 7 commits into from
Mar 8, 2017

Commits on Mar 8, 2017

  1. GOAWAY needs a maximum stream number in both directions 

    I have also taken the liberty of making the text that matches this
more directly applicable.
    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    31249be View commit details
    Browse the repository at this point in the history

  2. Advice on use of GOAWAY during error handling

    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    72dcfe0 View commit details
    Browse the repository at this point in the history

  3. Fix nits

    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    1ac4b8c View commit details
    Browse the repository at this point in the history

  4. I've taken feedback from #355. 

    I have also added text that captures something we learned late in the HTTP/2
experience.  GOAWAY pre-emptively closes streams, but for peer-initiated
streams it might make sense to use a bigger number to allow any requests that
the peer created in the last round trip to complete.  Some implementations find
retrying quite difficult and allowing (for example) a client's last set of
requests to complete can make the shutdown properly graceful (as opposed to
toy-graceful).

The case where this matters is for a gateway to server, where the gateway can't
reasonably retry the 10,000 requests that it initiated in the last second. To
allow for that, the server can give the gateway a bit of extra leeway for those
streams when it sends a GOAWAY frame.
    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    13a14f8 View commit details
    Browse the repository at this point in the history

  5. s/Last/Largest/ and improve conditions on a triggered GOAWAY

    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    ee7b808 View commit details
    Browse the repository at this point in the history

  6. Remove GOAWAY echo

    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    2c716f8 View commit details
    Browse the repository at this point in the history

  7. Remove error code and reason phrase from GOAWAY

    @martinthomson
    martinthomson committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    6fcb7f9 View commit details
    Browse the repository at this point in the history