Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reset pto_count on Initial ACKs #3551

Merged
merged 23 commits into from Apr 19, 2020
Merged

Do not reset pto_count on Initial ACKs #3551

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3dc10be
Do not reset pto_count on Initial ACKs
ianswett Mar 29, 2020
2c682ab
Update draft-ietf-quic-recovery.md
ianswett Mar 29, 2020
f31ae49
Revert reflow changes to keep them separate
ianswett Mar 29, 2020
c682269
Update draft-ietf-quic-recovery.md
ianswett Mar 29, 2020
50e0259
Set pto_count to 0 when dropping keys
ianswett Mar 29, 2020
85bb93e
Only do this for the client
ianswett Mar 30, 2020
96d2a6b
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
62544e2
Apply suggestions from code review
ianswett Mar 31, 2020
4b27838
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
5a7994c
Merge branch 'master' into ianswett-initial-pto
ianswett Apr 2, 2020
3bd99fb
Kazuho's suggestion
ianswett Apr 2, 2020
a1eff95
Apply suggestions from code review
ianswett Apr 9, 2020
53b4584
Update draft-ietf-quic-recovery.md
ianswett Apr 9, 2020
5226e28
Update draft-ietf-quic-recovery.md
ianswett Apr 9, 2020
e701772
Update draft-ietf-quic-recovery.md
ianswett Apr 9, 2020
e192b69
Update draft-ietf-quic-recovery.md
ianswett Apr 9, 2020
02069cd
Update draft-ietf-quic-recovery.md
ianswett Apr 9, 2020
1a1e49b
Update draft-ietf-quic-recovery.md
ianswett Apr 18, 2020
7826ec1
Update draft-ietf-quic-recovery.md
ianswett Apr 18, 2020
2687b58
Update draft-ietf-quic-recovery.md
ianswett Apr 18, 2020
beca7cd
Update draft-ietf-quic-recovery.md
ianswett Apr 19, 2020
1f178bd
Update draft-ietf-quic-recovery.md
ianswett Apr 19, 2020
eb93527
Update draft-ietf-quic-recovery.md
ianswett Apr 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -1145,8 +1145,9 @@ OnAckReceived(ack, pn_space):
OnPacketAcked(acked_packet.packet_number, pn_space)

DetectLostPackets(pn_space)
// Reset pto_count, unless the client receives an Initial ACK
if (endpoint is server || pn_space != Initial)
// Reset pto_count unless the server has not yet
// validated the client's address.
if (PeerCompletedAddressValidation())
pto_count = 0

SetLossDetectionTimer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be done only when pto_count is set to 0? Why restart the timer here if the pto_count hasn't changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new RTT measurement is available, so the alarm value should always be updated.

Expand Down