Forbid zero-length connection ID with preferred addresses #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
design
MikeBishop
approved these changes
Apr 7, 2020
ianswett
approved these changes
Apr 7, 2020
kazuho
approved these changes
Apr 7, 2020
marten-seemann
approved these changes
Apr 8, 2020
| : The Connection ID and Stateless Reset Token fields of a preferred address are | ||
| identical in syntax and semantics to the corresponding fields of a | ||
| NEW_CONNECTION_ID frame ({{frame-new-connection-id}}). A server that chooses | ||
| a zero-length connection ID MUST NOT provide a preferred address. Similarly, |
There was a problem hiding this comment.
I don't think this is right. NEW_CONNECTION_ID frames don't ban zero-length CIDs. What NEW_CONNECTION_ID bans is switching between zero-length CIDs and non-zero-length CIDs. If the server is using a zero-length CID, it should be allowed to switch to a preferred address, and also use zero-length CIDs there.
There was a problem hiding this comment.
Thanks for taking this to the issue.
NEW_CONNECTION_ID can't change to or from zero-length, so this is making this feature consistent with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is option 4 from the discussion in #3560. That is, making
preferred_address equivalent to NEW_CONNECTION_ID with a sequence number
of 1 in every way that matters.
Closes #3560.