Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify text around preferred address #3589

Merged
merged 10 commits into from
May 17, 2020
Merged

Clarify text around preferred address #3589

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8162c9a
Clarify existing requirements on CID use to consolidate expected beha…
ekinnear Apr 20, 2020
53c887e
Make {{issue-cid}} and {{retire-cid}} consistent
ekinnear Apr 20, 2020
0e1664e
Clarify handshake confirmed for preferred address, note that any CID …
ekinnear Apr 20, 2020
3cf8eaa
Apply suggestions from code review
erickinnear Apr 21, 2020
5509f1d
Review comments
ekinnear Apr 21, 2020
a6a266c
Merge branch 'master' into ek/preferred_address
martinthomson Apr 21, 2020
f7a9c3b
Refer to addresses instead of network paths
ekinnear May 12, 2020
a710194
Remove duplicate MUST
erickinnear May 13, 2020
ca0decd
Merge branch 'master' into ek/preferred_address
ekinnear May 14, 2020
77b06fc
Update whitespace for consistency
ekinnear May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2248,9 +2248,9 @@ address, for example when initiating connection migration as described in
{{probing}}.

Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
one destination address, for example when responding to a change in the address
of a peer if the packet with the new peer address uses an active connection ID
that has not been previously used by the peer.
one destination address. However, if an endpoint receives packets from a new
source address with the same destination connection ID, it MAY continue to use
the current connection ID with the new address.
erickinnear marked this conversation as resolved.
Show resolved Hide resolved

These requirements regarding connection ID reuse apply only to the sending of
packets, as unintentional changes in path without a change in connection ID are
Expand Down Expand Up @@ -2307,10 +2307,9 @@ IPv6) to allow clients to pick the one most suited to their network attachment.

Once the handshake is confirmed, the client SHOULD select one of the two
server's preferred addresses and initiate path validation (see
{{migrate-validate}}) of that address using the connection ID provided in the
preferred_address transport parameter or, if that connection ID has been
retired, any active connection ID that has not already been used on a different
path.
{{migrate-validate}}) of that address using any previously unused active
connection ID, taken from either the preferred_address transport parameter or
a NEW_CONNECTION_ID frame.

If path validation succeeds, the client SHOULD immediately begin sending all
future packets to the new server address using the new connection ID and
Expand Down Expand Up @@ -5581,8 +5580,8 @@ Sequence Number:

Retire Prior To:

: A variable-length integer indicating which connection IDs should be retired.
See {{retire-cid}}.
: A variable-length integer indicating which connection IDs should be retired;
see {{retire-cid}}.

Length:

Expand Down Expand Up @@ -5662,8 +5661,7 @@ RETIRE_CONNECTION_ID frames contain the following fields:

Sequence Number:

: The sequence number of the connection ID being retired; see
{{retire-cid}}.
: The sequence number of the connection ID being retired; see {{retire-cid}}.

Receipt of a RETIRE_CONNECTION_ID frame containing a sequence number greater
than any previously sent to the peer MUST be treated as a connection error of
Expand Down