[HTTP3] Clarify reserved values. #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify reserved values for stream types, settings identifiers, frame types, and error codes. 0x1f * N + 0x21 for the value of N = -1 is 0x02. Literal interpretation of the current text includes this as a reserved value. The parenthetical examples given in Section 11.2 make it clear that this was not the intention, rendering this PR editorial. The main motivation of this PR is not that the current text is inconsistent, but that parenthetical examples from 11.2 are necessary to correctly interpret the definitions in sections 6.2.3, 7.2.4.1, 7.2.8, and 8.1. Alternative wordings could be: "0x1f * N + 0x21 for N = 0, 1, 2, ..." "0x1f * N + 0x02 for positive integer values of N" "0x1f * N + 0x02 for N = 1, 2, 3, ..." "0x21, 0x21 + 0x1f, 0x21 + 2 * 0x1f, ..." "a value of at least 0x21 with a remainder of 0x02 modulo 0x1f" "a value of at least 0x21 that is congruent to 0x21 modulo 0x1f" none of which is better than what this PR proposes.
ianswett
added
-http
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify reserved values for stream types, settings identifiers, frame
types, and error codes.
0x1f * N + 0x21 for the value of N = -1 is 0x02. Literal interpretation
of the current text includes this as a reserved value. The
parenthetical examples given in Section 11.2 make it clear that this was
not the intention, rendering this PR editorial.
The main motivation of this PR is not that the current text is
inconsistent, but that parenthetical examples from 11.2 are necessary to
correctly interpret the definitions in sections 6.2.3, 7.2.4.1, 7.2.8,
and 8.1.
Alternative wordings could be:
"0x1f * N + 0x21 for N = 0, 1, 2, ..."
"0x1f * N + 0x02 for positive integer values of N"
"0x1f * N + 0x02 for N = 1, 2, 3, ..."
"0x21, 0x21 + 0x1f, 0x21 + 2 * 0x1f, ..."
"a value of at least 0x21 with a remainder of 0x02 modulo 0x1f"
"a value of at least 0x21 that is congruent to 0x21 modulo 0x1f"
none of which is better than what this PR proposes.