Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet number echo with fixed-length, 32-bit packet and echo numbers #368

Closed

Conversation

britram
Copy link
Contributor

@britram britram commented Mar 7, 2017

This is a version of #367 (replacing #351 manually rebased on #361), that sets packet numbers and packet number echoes in short headers to 32-bits, mainly by cutting complexity out of #367.

@britram britram mentioned this pull request Mar 7, 2017

The packet type in a short header currently determines only the size of the
packet number field. Additional types can be used to signal the presence of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first sentence no longer applies. Probably just want to say:

The packet type is used to determine the fields that are present in a short header and their length.

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase?

@britram
Copy link
Contributor Author

britram commented Mar 13, 2017

Replaced by #393.

@britram britram closed this Mar 13, 2017
@britram britram deleted the packet-number-echo-four-octets-suffice branch March 13, 2017 11:14
@martinthomson
Copy link
Member

@britram, it's OK to force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants