Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet number echo with fixed-length, 32-bit packet and echo numbers #368

Closed

Conversation

Projects
None yet
3 participants
@britram
Copy link
Contributor

britram commented Mar 7, 2017

This is a version of #367 (replacing #351 manually rebased on #361), that sets packet numbers and packet number echoes in short headers to 32-bits, mainly by cutting complexity out of #367.

@britram britram referenced this pull request Mar 7, 2017

Closed

Packet number echo #351


The packet type in a short header currently determines only the size of the
packet number field. Additional types can be used to signal the presence of

This comment has been minimized.

Copy link
@martinthomson

martinthomson Mar 8, 2017

Member

This first sentence no longer applies. Probably just want to say:

The packet type is used to determine the fields that are present in a short header and their length.

britram added some commits Mar 8, 2017

@janaiyengar
Copy link
Contributor

janaiyengar left a comment

Can you rebase?

@britram

This comment has been minimized.

Copy link
Contributor Author

britram commented Mar 13, 2017

Replaced by #393.

@britram britram closed this Mar 13, 2017

@britram britram deleted the britram:packet-number-echo-four-octets-suffice branch Mar 13, 2017

@martinthomson

This comment has been minimized.

Copy link
Member

martinthomson commented Mar 13, 2017

@britram, it's OK to force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.