Update Initial salt, Retry keys, and samples (#3711) to changelog #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
added
-tls
editorial
|
Shouldn't this PR be against the -tls changelog? |
alagoutte
force-pushed
the
changelog_draft29_update_initial_salt
branch
from
c426f56
to
faab2c4
Compare
Lekensteyn
approved these changes
Jun 10, 2020
|
Does this need to be in the changelog? The changelog doesn't state that the version number changed, and I view the initial salts as deeply tied to the version number. |
|
Both Lars and David are right. This is a change limited to the -tls draft. We haven't listed changed keying material in previous changelogs. Of course, because we haven't been consistent about updating them, I can see why you might want what appears to be an exception called out. |
|
it is now on tls doc and if you look there is already on changelog info about initial salt update (draft-22...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.