Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use plausible TLS messages #3753

Merged
merged 3 commits into from Jun 30, 2020
Merged

Use plausible TLS messages #3753

merged 3 commits into from Jun 30, 2020

Commits on Jun 10, 2020

  1. Make the TLS messages plausible 

    Here is the breakdown of the ClientHello:

```
060040f1 = CRYPTO offset 0, length 241
010000ed = TLS Handshake length 237
0303 = version: TLS 1.2
ebf8fa56f12939b9584a3896472ec40bb863cfd3e86804fe3a47f06a2b69484c = random
00 = legacy_session_id
0004 13011302 = cipher_suites: TLS_AES_128_GCM_SHA256, TLS_AES_256_GCM_SHA384
0100 = legacy_compression_methods: none
00e0 = extensions length 194
0000 0010 000e 00 000b 6578616d706c652e636f6d = server name: example.com
ff01 0001 00 = renegotiation info
000a 0008 0006 001d00170018 = supported groups: 25519, P-256, P-384
0010 0007 000504616c706e = alpn: h3-28
0005 0005 0100000000 = certificate status
0033 0026 0024001d00209370b2c9caa47fbabaf4559fedba753de171fa71f50f1ce15d43e994ec74d748 = key share: 25519
002b 0003 020304 = supported versions: TLS 1.3
000d 0010 000e 0403050306030203080408050806 = signature algorithms: some irrelevant stuff here
002d 0002 0101 = psk modes: psk+dh
001c 0002 4001 = record size limit: max
ffa5 0032 = QUIC transport parameters extension
04 08 ffffffffffffffff = initial_max_data 2^62-1
05 04 8000ffff = initial_max_stream_data_bidi_local 2^16-1
07 04 8000ffff = initial_max_stream_data_uni 2^16-1
08 01 10 = initial_max_streams_bidi 16
01 04 80007530 = max_idle_timeout 30s
09 01 10 = initial_max_streams_uni 16
0f 08 8394c8f03e515708 = initial_source_connection_id
06 04 8000ffff = initial_max_stream_data_bidi_remote 2^16-1
```

The ServerHello was OK, but the framing wasn't.
    @martinthomson
    martinthomson committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9a7ef22 View commit details
    Browse the repository at this point in the history

  2. Update samples in the draft based on changed content

    @martinthomson
    martinthomson committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0b46816 View commit details
    Browse the repository at this point in the history

  3. Fix bad extension length

    @martinthomson
    martinthomson committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    ab3d19b View commit details
    Browse the repository at this point in the history