Use handshake bytes more consistently #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a paragraph about buffering of CRYPTO frames that references the buffering text in the transport doc. Closes no issue, but there have been complaints.
martinthomson
added
editorial
marten-seemann
approved these changes
Jun 18, 2020
janaiyengar
approved these changes
Jun 18, 2020
MikeBishop
approved these changes
Jun 23, 2020
| space. | ||
| bytes to be sent, they are appended to the handshake bytes for the current | ||
| encryption level. Any packet that includes the CRYPTO frame is protected using | ||
| keys from the corresponding encryption level. |
There was a problem hiding this comment.
Not new text, but this feels like it's reversed. It's not the fact that it includes these bytes that causes a packet to use particular keys; the level of these bytes determines which packet type it must be sent in.
There was a problem hiding this comment.
#3783 is an attempt to invert this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a paragraph about buffering of CRYPTO frames that
references the buffering text in the transport doc.
Closes no issue, but there have been complaints.