Flow control accounting uses the maximum data offset on each stream #378
Conversation
draft-ietf-quic-transport.md
Outdated
|
|
||
| An endpoint accounts for the maximum offset of data that is sent or received on | ||
| a stream. Loss or reordering can mean that the size of STREAM frames can be | ||
| less than the maximum data offset on a stream; similarly, STREAM frames might |
There was a problem hiding this comment.
What does the size of a STREAM frame have to do with the maximum offset?
There was a problem hiding this comment.
"...can mean that the maximum offset is greater than the total size of data received on a stream."
draft-ietf-quic-transport.md
Outdated
| of 1024 octets. That is, the value here is multiplied by 1024 to determine | ||
| the actual flow control offset. The sender of this parameter sets the byte | ||
| offset for connection level flow control to this value. This is equivalent to | ||
| sending a WINDOW_UPDATE ({{frame-window-update}}) for stream 0 immediately |
There was a problem hiding this comment.
Better: for the connection. There is no stream 0.
draft-ietf-quic-transport.md
Outdated
|
|
||
| An endpoint accounts for the maximum offset of data that is sent or received on | ||
| a stream. Loss or reordering can mean that the size of STREAM frames can be | ||
| less than the maximum data offset on a stream; similarly, STREAM frames might |
There was a problem hiding this comment.
"...can mean that the maximum offset is greater than the total size of data received on a stream."
draft-ietf-quic-transport.md
Outdated
| An endpoint accounts for the maximum offset of data that is sent or received on | ||
| a stream. Loss or reordering can mean that the size of STREAM frames can be | ||
| less than the maximum data offset on a stream; similarly, STREAM frames might | ||
| not cause the maximum offset on a stream. A STREAM frame with a FIN bit set or |
There was a problem hiding this comment.
"...might not cause the maximum offset on a stream to increase."
| : A 64-bit unsigned integer indicating the flow control offset for the given | ||
| stream (for a stream ID other than 0) or the entire connection. | ||
|
|
||
| The flow control offset is expressed in units of octets for individual streams |
There was a problem hiding this comment.
Why not use a 1K multiplier for both stream and connection-level?
There was a problem hiding this comment.
I considered it, but streams don't need as much space and they might benefit from a more granular expression of where they are up to. We can refine this later.
Also, scales the connection-level flow control window by 1024
Closes #370, #340, #192.
Note: I was just going to fix these separately, but they both hit exactly the same text. Seemed like I might as well kill two birds.