Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both error types for >2^60 in MAX_STREAMS #3792

Closed
wants to merge 1 commit into from

Conversation

martinthomson
Copy link
Member

STREAM_LIMIT_ERROR is fine.
FRAME_ENCODING_ERROR is fine.

We just need to be consistent in mentioning both throughout.

Closes #3781.

STREAM_LIMIT_ERROR is fine.
FRAME_ENCODING_ERROR is fine.

We just need to be consistent in mentioning both throughout.

Closes #3781.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jun 26, 2020
@marten-seemann
Copy link
Contributor

I'd prefer to not make this change. STREAM_LIMIT_ERRORs only occur when the peers tries to open a stream with a too high stream ID, not when the peer is granting you a higher stream budget.
As this stream ID doesn't even exist, this is clearly a FRAME_ENCODING_ERROR.

@martinthomson
Copy link
Member Author

That's a reasonable position. That says that STREAM_LIMIT_ERROR is only for violations of a limit, not for mistakes in setting it. That keeps the blame firmly on one side of the fence.

I saw the opposite angle too: the frame type in CONNECTION_CLOSE does provide a way to disambiguate source. STREAM_LIMIT_ERROR+MAX_STREAMS is fairly clear.

@ianswett
Copy link
Contributor

I agree with @marten-seemann in this case based on the principles we've previously outlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor inconsistency of error when MAX_STREAMS exceeds 2^60
3 participants