New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More about authenticating Version Negotiation #3871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that it is a mechanism in the target QUIC version that authenticates the information. This also lifts the strong requirement on authenticating the contents of Version Negotiation. QUIC version 1 does not do this and so does not comply with this requirement. The intent was always that only information that is used needs to be authenticated in this way. (This is a tiny bit of evasion as Version Negotiation is used in QUIC version 1 as a signal that a version is not supported, which results in clients abandoning connections.) Closes #3828.
martinthomson
added
editorial
An issue that does not affect the design of the protocol; does not require consensus.
-invariants
labels
Jul 8, 2020
martinthomson
commented
Jul 14, 2020
MikeBishop
reviewed
Jul 14, 2020
draft-ietf-quic-invariants.md
Outdated
@@ -334,8 +334,8 @@ requires that middleboxes retain state for every connection ID they see. | |||
|
|||
The Version Negotiation packet described in this document is not | |||
integrity-protected; it only has modest protection against insertion by off-path | |||
attackers. QUIC versions MUST define a mechanism that authenticates the values | |||
it contains. | |||
attackers. A QUIC version that uses a Version Negotiation packet MUST define a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One could still argue that QUIC v1 "uses" the VN packet to indicate lack of support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
attackers. A QUIC version that uses a Version Negotiation packet MUST define a | |
attackers. A specification that permits clients to change the QUIC version in | |
use based on the contents of a Version Negotiation packet MUST also define a |
Something like this?
ianswett
approved these changes
Jul 14, 2020
janaiyengar
reviewed
Jul 14, 2020
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-invariants
editorial
An issue that does not affect the design of the protocol; does not require consensus.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that it is a mechanism in the target QUIC version that
authenticates the information.
This also lifts the strong requirement on authenticating the contents of
Version Negotiation. QUIC version 1 does not do this and so does not
comply with this requirement. The intent was always that only
information that is used needs to be authenticated in this way.
(This is a tiny bit of evasion as Version Negotiation is used in QUIC
version 1 as a signal that a version is not supported, which results in
clients abandoning connections.)
Closes #3828.