New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior around key availability delays during handshake #3874
Merged
janaiyengar
merged 35 commits into
quicwg:master
from
kazuho:kazuho/pto-vs-key-generation
Sep 1, 2020
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f851c8c
allow endpoints to generate traffic keys asynchronously, write down t…
kazuho 6e54f3e
QUIC does not generate keys, TLS provides them
kazuho 964fd96
Rearrange the text, based on @marten-seeman's point that the intent o…
kazuho 2e6bc76
both endpoints refrain from sending probes before obtaining the read …
kazuho 784b062
explicitly state from which PN spaces to choose
kazuho 8334a5e
MT's suggestion
kazuho a77e003
Update draft-ietf-quic-recovery.md
kazuho e024864
Jana's suggestions
kazuho 07a668e
based on the established rationale, PTO should be disabled until the …
kazuho 9a008e7
Apply suggestions from code review
janaiyengar 5e25bcd
Resolution from #3821 (pseudocode missing)
janaiyengar 7f22ad8
agreed changes from editors meeting
janaiyengar 728dc37
mt's comments
janaiyengar 1029078
kazuho corrections
janaiyengar 9821f07
s/MAY/SHOULD, and some editorializing
janaiyengar 1fe9727
undo SHOULD
janaiyengar 0000ceb
Add para on local delays when ack is buffered
janaiyengar 8083104
Apply suggestions from code review
janaiyengar 3d26a53
more changes
janaiyengar e796999
fix ref
janaiyengar ef2a714
tightening
janaiyengar 4c41f55
Apply suggestions from code review
janaiyengar 7f87ff7
move local delay para up
janaiyengar 6635adb
Ian's comments
janaiyengar ddb4b86
Update draft-ietf-quic-recovery.md
janaiyengar 0b9b2e1
RTT
janaiyengar 936c4a0
more comments
janaiyengar e7d423e
Ian's comments
janaiyengar 721ee00
s/ack immediately/not delay intentionally
janaiyengar 952952a
Martin's concern in #4035
janaiyengar 99d976f
kazuho's comments
janaiyengar 2a50ecd
kazuho's comments
janaiyengar 95988d7
Update draft-ietf-quic-recovery.md
janaiyengar cae02dc
reference for why Initial packets won't be delayed
janaiyengar 1a02636
Merge branch 'master' into kazuho/pto-vs-key-generation
janaiyengar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful distinction -- endpoints that are unable to process acks because keys aren't there can simply drop those packets too. That won't reflect in the delay.