Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change an assert in OnLossDetectionTimeout #3916

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Change an assert in OnLossDetectionTimeout #3916

merged 1 commit into from
Jul 17, 2020

Conversation

ianswett
Copy link
Contributor

Fixes #3912

@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Jul 16, 2020
@janaiyengar janaiyengar merged commit 7e2536b into master Jul 17, 2020
@janaiyengar janaiyengar deleted the ianswett-assert-lossdetectiontimeout branch July 17, 2020 00:34
@kazu-yamamoto
Copy link
Contributor

I confirmed that the assertion failure disappeared with this modification. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assertion in OnLossDetectionTimeout of recovery draft
4 participants
@ianswett @kazu-yamamoto @martinthomson @janaiyengar