Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework flow of Push ID #3925

Merged
merged 8 commits into from Aug 11, 2020
Merged

Rework flow of Push ID #3925

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0764b9d
Rework flow of Push ID
MikeBishop Jul 21, 2020
836b5bb
Feedback from Bence/Lucas
MikeBishop Jul 21, 2020
b85e25d
Apply suggestions from code review
MikeBishop Jul 22, 2020
5542b52
Update draft-ietf-quic-http.md
MikeBishop Jul 22, 2020
a248e98
Not additional
MikeBishop Jul 28, 2020
f1528a3
Update draft-ietf-quic-http.md
MikeBishop Aug 11, 2020
a093f3e
Merge remote-tracking branch 'origin/master' into http/push_flow
MikeBishop Aug 11, 2020
6d90ab7
Rewrap
MikeBishop Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-http.md
View file
Open in desktop
Expand Up @@ -820,7 +820,7 @@ Push ID as a connection error of type H3_ID_ERROR.

The Push ID is used in one or more PUSH_PROMISE frames ({{frame-push-promise}})
that carry the header section of the request message. These frames are sent on
the request stream which generated the push. This allows the server push to be
the request stream that generated the push. This allows the server push to be
associated with a client request. When the same Push ID is promised on multiple
request streams, the decompressed request field sections MUST contain the same
fields in the same order, and both the name and the value in each field MUST be
Expand Down Expand Up @@ -919,8 +919,8 @@ The GOAWAY frame contains an identifier that indicates to the receiver the range
of requests or pushes that were or might be processed in this connection. The
server sends a client-initiated bidirectional Stream ID; the client sends a Push
ID ({{server-push}}). Requests or pushes with the indicated identifier or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ID ({{server-push}}). Requests or pushes with the indicated identifier or
ID; see {{server-push}}. Requests or pushes with the indicated identifier or

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That reference informs the specific term, not the whole statement; I think the parentheses are more appropriate in this instance.

greater are rejected by the sender of the GOAWAY. This identifier MAY be zero
if no requests or pushes were processed.
greater are rejected ({{request-cancellation}}) by the sender of the GOAWAY.
This identifier MAY be zero if no requests or pushes were processed.

The information in the GOAWAY frame enables a client and server to agree on
which requests or pushes were accepted prior to the connection shutdown. Upon
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.