Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time loss detection and early retransmit #394

Merged
merged 3 commits into from Mar 13, 2017
Merged

Fix time loss detection and early retransmit #394

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876df8f
Fix time loss detection and early retransmit
ianswett Mar 13, 2017
26bd685
Fix trailing whitespace
ianswett Mar 13, 2017
55d791c
Fix inconsistencies and nits
ianswett Mar 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -233,7 +233,7 @@ reordering_threshold:
: The largest delta between the largest acked
retransmittable packet and a packet containing retransmittable frames before
it's declared lost.

time_reordering_fraction:
: The reordering window as a fraction of max(smoothed_rtt, latest_rtt).

Expand Down Expand Up @@ -503,7 +503,7 @@ Pseudocode for DetectLostPackets follows:
lost_packets.insert(unacked)
else if (loss_time == 0 && time_when_lost != 0):
loss_time = time_when_lost - time_since_sent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here saying something like "loss_time is used for setting the loss detection alarm later."


// Inform the congestion controller of lost packets and
// lets it decide whether to retransmit immediately.
OnPacketsLost(lost_packets)
Expand Down