Editorial nits for HTTP #3942
Merged
Editorial nits for HTTP #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
added
editorial
MikeBishop
commented
Jul 22, 2020
| @@ -2406,7 +2416,7 @@ INADEQUATE_SECURITY (0xc): | |||
| : Not applicable, since QUIC is assumed to provide sufficient security on all | |||
| connections. | |||
|
|
|||
| H3_1_1_REQUIRED (0xd): | |||
| HTTP_1_1_REQUIRED (0xd): | |||
There was a problem hiding this comment.
HTTP 3.1.1 for Workgroups, perhaps?
martinthomson
approved these changes
Jul 23, 2020
| @@ -2406,7 +2416,7 @@ INADEQUATE_SECURITY (0xc): | |||
| : Not applicable, since QUIC is assumed to provide sufficient security on all | |||
| connections. | |||
|
|
|||
| H3_1_1_REQUIRED (0xd): | |||
| HTTP_1_1_REQUIRED (0xd): | |||
There was a problem hiding this comment.
HTTP 3.1.1 for Workgroups, perhaps?
Co-authored-by: Martin Thomson <mt@lowentropy.net>
ianswett
approved these changes
Jul 27, 2020
bencebeky
approved these changes
Jul 29, 2020
draft-ietf-quic-http.md
Outdated
| @@ -1167,8 +1172,7 @@ receipt. | |||
|
|
|||
| The payload and length of the stream are selected in any manner the | |||
| implementation chooses. Implementations MAY terminate these streams cleanly, or | |||
| MAY abruptly terminate them. When terminating abruptly, the error code | |||
| H3_NO_ERROR or a reserved error code ({{http-error-codes}}) SHOULD be used. | |||
There was a problem hiding this comment.
What is the rationale for removing this sentence?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those that didn't seem to warrant separate issues, anyway.