Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPACK SC: No encoder memory for blocked #4008

Merged
merged 3 commits into from
Aug 18, 2020
Merged

QPACK SC: No encoder memory for blocked #4008

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f05864f
No encoder memory for blocked
MikeBishop Aug 17, 2020
4bdcea5
Caution
MikeBishop Aug 18, 2020
064a3d6
@afrind's feedback
MikeBishop Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion draft-ietf-quic-qpack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,8 @@ additional state memory on the encoder.
An encoder allocates memory to track all dynamic table references in
unacknowledged representations. Implementations can directly limit the amount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

representations are not acknowledged, encoded field section blocks are, right?

of state memory by only using as many references to the dynamic table as it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject/pronoun agreement: "Implementations can...as it wishes". Perhaps "An implementation can..."

wishes to track; no signaling to the decoder is required.
wishes to track; no signaling to the decoder is required. However, limiting
references to the dynamic table will reduce compression effectiveness.

The amount of temporary memory consumed by an encoder or decoder can be limited
by processing header fields sequentially. A decoder implementation does not need
Expand Down