Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gorry's ECN rewrite #4059

Merged
merged 16 commits into from
Sep 15, 2020
Merged

Gorry's ECN rewrite #4059

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d2ada7e
Gorry's ECN rewrite, verbatim
martinthomson Aug 26, 2020
2a96678
fix nits; reorder
martinthomson Aug 26, 2020
245c51c
Many suggestions
martinthomson Sep 7, 2020
a00bb9b
My own suggestion
martinthomson Sep 7, 2020
0a22dfe
Review feedback
martinthomson Sep 8, 2020
a6928b3
Boundary conditions for validation
martinthomson Sep 8, 2020
70e43d5
Wrap
martinthomson Sep 8, 2020
05e3f85
Merge branch 'master' into gorry-ecn-rewrite
martinthomson Sep 9, 2020
69f1f5f
Ian had some good suggestions
martinthomson Sep 10, 2020
1801df5
Period
martinthomson Sep 10, 2020
1a28ce1
ECN field when talking about the field, marking or codepoint only for…
martinthomson Sep 10, 2020
4333941
Just one per
martinthomson Sep 10, 2020
96c8c6f
Reword again
martinthomson Sep 10, 2020
5c39ab2
Update heading
martinthomson Sep 13, 2020
0bcbe5c
Lars' review suggestions
martinthomson Sep 14, 2020
fbfd077
Wrap
martinthomson Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3907,8 +3907,9 @@ ECN counts. Coalesced QUIC packets (see {{packet-coalesce}}) share the same IP
header so the ECN counts are incremented once for each coalesced QUIC packet.

For example, if one each of an Initial, Handshake, and 1-RTT QUIC packet are
coalesced into a single UDP datagram, the ECN counts for all three packet
number spaces will be incremented by one each, based on the ECN field of the single IP header.
coalesced into a single UDP datagram, the ECN counts for all three packet number
spaces will be incremented by one each, based on the ECN field of the single IP
header.

ECN counts are only incremented when QUIC packets from the received IP
packet are processed. As such, duplicate QUIC packets are not processed and
Expand Down Expand Up @@ -3958,11 +3959,10 @@ processed ACK frame. Any increase in the ECN counts is validated based on the
ECN markings that were applied to packets that are newly acknowledged in the ACK
frame.

If an ACK frame newly acknowledges a packet that the endpoint sent with
either the ECT(0) or ECT(1) codepoint set, ECN validation fails if the
corresponding ECN counts are not present in the ACK frame. This check detects a
network element that zeroes the ECN field or a peer that does not report
ECN markings.
If an ACK frame newly acknowledges a packet that the endpoint sent with either
the ECT(0) or ECT(1) codepoint set, ECN validation fails if the corresponding
ECN counts are not present in the ACK frame. This check detects a network
element that zeroes the ECN field or a peer that does not report ECN markings.

ECN validation also fails if the sum of the increase in ECT(0) and ECN-CE counts
is less than the number of newly acknowledged packets that were originally sent
Expand Down