Fix conflicting error codes #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess technically we could have let both of these stand and used the same error code for both conditions, but that seems unnecessary. Moving the AEAD limit seems easier. Closes #4087.
martinthomson
added
design
ianswett
approved these changes
Sep 10, 2020
janaiyengar
approved these changes
Sep 11, 2020
marten-seemann
approved these changes
Sep 11, 2020
geraldcombs
pushed a commit
to wireshark/wireshark
that referenced
this pull request
Sep 12, 2020
Update value_string version (0x000e) Add AEAD_LIMIT_REACHED (0xf) Error (with conflict fix : quicwg/base-drafts#4088) Issue #13881
chris-wood
approved these changes
Sep 12, 2020
nibanks
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess technically we could have let both of these stand and used the
same error code for both conditions, but that seems unnecessary. Moving
the AEAD limit seems easier.
Closes #4087.