Remove recommendation to not include tokens #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another judgment call, but as this wasn't a MUST in the first place, we weren't really preventing an attack. This just removes the recommendation to remove NEW_TOKEN tokens from Initial packets to new server addresses. It leaves the generic guidance, which is far more nuanced. I've added some commentary about the effect of withholding tokens on performance, as it seems like that is worth highlighting here. All in all, this leans more toward saying that request forgery is not the responsibility of QUIC deployments. Closes #4076.
martinthomson
added
design
ianswett
approved these changes
Sep 10, 2020
DavidSchinazi
approved these changes
Sep 10, 2020
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
|
I'm merging this. If anyone thinks this ought to be dealt with differently, please say so on this PR or on the issue, and we can revisit. |
|
Apologies for merging this PR. @LPardue @larseggert : we should still run #4076 through the process as a design issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another judgment call, but as this wasn't a MUST in the first
place, we weren't really preventing an attack. This just removes the
recommendation to remove NEW_TOKEN tokens from Initial packets to new
server addresses.
It leaves the generic guidance, which is far more nuanced.
I've added some commentary about the effect of withholding tokens on
performance, as it seems like that is worth highlighting here.
All in all, this leans more toward saying that request forgery is not
the responsibility of QUIC deployments.
Closes #4076.