Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor editorial nits in Section 10 (Connection Termination) #4129

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@ianswett ianswett added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Sep 22, 2020
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
Comment on lines 2768 to 2769
Violations of the protocol lead to an immediate close, and a transport-level
error being sent in a CONNECTION_CLOSE frame.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Violations of the protocol lead to an immediate close, and a transport-level
error being sent in a CONNECTION_CLOSE frame.
Violations of the protocol lead to an immediate close, with a transport-level
error being sent in the CONNECTION_CLOSE frame.

I'm not sure ", and" is the right conjunction here; it sounds like two outcomes.

Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I like @martinthomson suggestion

@janaiyengar janaiyengar merged commit 7d5273b into quicwg:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants