fix incorrect statement about varint usage #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
requested review from
janaiyengar and
martinthomson
as code owners
larseggert
reviewed
Sep 22, 2020
marten-seemann
commented
Sep 22, 2020
draft-ietf-quic-transport.md
Outdated
| Versions ({{versions}}) and error codes ({{error-codes}}) are described using | ||
| integers, but do not use this encoding. | ||
| Versions ({{versions}}) and packet numbers sent in the header | ||
| ({{packet-encoding}}) are described using integers, but do not use this encoding. |
There was a problem hiding this comment.
Technically, this also applies to all CID length fields. Not sure if it’s worth mentioning here.
marten-seemann
force-pushed
the
varint-usage
branch
from
4164866
to
9a064e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error codes do use varints, but packet numbers (in the header) don't.