Migration can be unpermitted #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
added
editorial
MikeBishop
requested review from
janaiyengar and
martinthomson
as code owners
janaiyengar
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
LGTM, but one nit. I'd like @martinthomson to review this too.
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading over the text in the sections @ekr commented on, it feels like the heart of the conflict is this:
Additionally, we've discussed mitigations to other issues (e.g. #3765) in which a server might consider certain probes/migrations unacceptable and simply not respond to them. That possibility isn't currently discussed in the text.
The solution to both appears to be the same: Condition the MUST on acceptance of the migration. If the migration is somehow unacceptable (the remote address violates some deployment-specific rule, or the migration is prohibited by this version of QUIC) these requirements simply don't attach. The recipient doesn't change where they're sending packets or validate the new address. That might mean the connection fails rather than migrating, but that's the price you pay.
I think this is editorial, because it acknowledges a carve-out in the MUST that we've always implicitly used to accommodate other text in the doc.
Fixes #4063.