Validate ECN for up to 3 PTO #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to just make a note here saying "if you don't send many packets, you won't send many packets", but then decided that 3PTO is probably more sensible. As it is, 3 RTT is the value that the PTO is initialized to (validation almost always happens on a new path). And the loss of a single packet just doesn't cut it. Even 3 packets (the first packet, plus two on PTO, assuming two are sent on PTO) is not that strong, but at least it isn't insanely tight. Closes #4132.
ianswett
approved these changes
Sep 24, 2020
ianswett
approved these changes
Sep 24, 2020
janaiyengar
reviewed
Sep 24, 2020
janaiyengar
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to just make a note here saying "if you don't send many packets,
you won't send many packets", but then decided that 3PTO is probably
more sensible. As it is, 3 RTT is the value that the PTO is initialized
to (validation almost always happens on a new path). And the loss of a
single packet just doesn't cut it. Even 3 packets (the first packet,
plus two on PTO, assuming two are sent on PTO) is not that strong, but
at least it isn't insanely tight.
Closes #4132.