Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and clarify RTO alarm calculation #417

Merged
merged 1 commit into from Mar 28, 2017
Merged

Simplify and clarify RTO alarm calculation #417

merged 1 commit into from Mar 28, 2017

Conversation

ianswett
Copy link
Contributor

No description provided.

@ianswett
Copy link
Contributor Author

Intended to fix Issue #142

martinduke
martinduke approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@martinduke martinduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. The previous wording seemed to imply we were doubling the previous timeout, rather than recalculating based on the current srtt.

What you have here is much easier and equivalent to what most TCP implementations do (I believe)

@ianswett ianswett merged commit 673e295 into master Mar 28, 2017
@martinthomson martinthomson deleted the ianswett-rto-calculation branch April 21, 2017 05:27
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -recovery labels May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinduke martinduke martinduke approved these changes

Assignees
No one assigned
Labels
-recovery design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianswett @martinduke @martinthomson