Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify CID length requirements for VN packets #4187

Merged
merged 4 commits into from
Oct 15, 2020
Merged

clarify CID length requirements for VN packets #4187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fc4a11
add text about CID lengths to the invariants
marten-seemann Oct 8, 2020
ec17412
clarify that future QUIC versions might have different CID length req…
marten-seemann Oct 8, 2020
05cc5d9
use @martinthomson's suggestion for the invariants
marten-seemann Oct 9, 2020
3fec711
apply @martinthompson's and @MikeBishop's suggestions
marten-seemann Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions draft-ietf-quic-invariants.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,9 @@ connection IDs gives clients some assurance that the server received the packet
and that the Version Negotiation packet was not generated by an off-path
attacker.

Version-specific rules for QUIC packets MUST NOT influence a server decision

This comment was marked as resolved.

Sign in to view

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the transport doc is fine; this is, as David says, a little sketchy without the minimum length constraint. A prefix of "other than the minimum packet size, ..." might work, I guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or scope the MUST NOT specifically to CID interpretation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this proposal is unclear on what the "MUST NOT" is for.

about whether to send a Version Negotiation packet.

An endpoint that receives a Version Negotiation packet might change the version
that it decides to use for subsequent packets. The conditions under which an
endpoint changes QUIC version will depend on the version of QUIC that it
Expand Down
8 changes: 5 additions & 3 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4554,9 +4554,11 @@ connection IDs gives clients some assurance that the server received the packet
and that the Version Negotiation packet was not generated by an off-path
attacker.

As future versions of QUIC may support Connection IDs larger than the version 1
limit, Version Negotiation packets could carry Connection IDs that are longer
than 20 bytes.
Future versions of QUIC may have different requirements for the lengths of
connection IDs. In particular, connection IDs might have a smaller minimum
length or a greater maximum length. Version-specific rules for QUIC packets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the context of the first new sentence the second sentence is clearly apply to CIDs, but it indicates that there might be other aspects. What aspects are not invariant here?

therefore MUST NOT influence a server decision about whether to send a Version
Negotiation packet.

The remainder of the Version Negotiation packet is a list of 32-bit versions
that the server supports.
Expand Down